Add GRPC dial options support to etcd cluster options #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRPC dial options are useful for a variety of use cases--adding default headers (via a stream interceptor), injecting code into the low level connection flow via a net.Dialer (e.g. to support proxying across network boundaries). This diff adds an option on clusters to pass through GRPC.DialOptions for these use cases. Defaults of nil should match current behavior.
andrewmains12
force-pushed
the
amains/etcd_dial_options
branch
from
3f15d4d
to
62e9d3d
Compare
justinjc
approved these changes
Feb 9, 2022
andrewmains12
added a commit
that referenced
this pull request
Feb 24, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 24, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 24, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 24, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 24, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 25, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 25, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 25, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 25, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 28, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 28, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
andrewmains12
added a commit
that referenced
this pull request
Feb 28, 2022
Similar idea to #4066, except for m3msg, and specific to allowing customization of net.Dial behavior. This is useful for e.g. proxying across network boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
GRPC dial options are useful for a variety of use cases--adding default headers (via a stream interceptor), injecting code into the low level connection flow via
a net.Dialer (e.g. to support proxying across network boundaries).
This diff adds an option on clusters to pass through GRPC.DialOptions for these use cases. Defaults of nil should match current behavior.
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: