[commitlog] Add the ability to configure pools before allocation #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several places where we allocate large pools of memory in constructors and provide setters to override those pools. In general, this is fine as it allows us to provide larger or smaller pools. However, in super memory constrained settings, we prefer to avoid the initial alloc and GC all together and provide the properly sized pools to the constructor. This PR provides the ability to do this for certain properties of fs.Options and commitlog.Options.
marcushill
changed the title
shreyassrivatsan
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places where we allocate large pools of memory
in constructors and provide setters to override those pools.
In general, this is fine as it allows us to provide larger or smaller
pools. However, in super memory constrained settings, we prefer to
avoid the initial alloc and GC all together and provide
the properly sized pools to the constructor.
This PR provides the ability to do this for certain properties
of fs.Options and commitlog.Options.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: