Add m3coordinator Dockerfile and update Prometheus test to use standalone coordinator #792
Conversation
…e standalone coordinator
| LABEL maintainer="The M3DB Authors <m3db@googlegroups.com>" | ||
|
|
||
| # Install Glide | ||
| RUN apk add --update glide git make bash |
There was a problem hiding this comment.
We should reuse these steps across the Dockerfiles at some point, but let's just move forward quickly for now to unblock others using the images?
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
- Coverage 78.38% 78.21% -0.18%
==========================================
Files 363 363
Lines 30812 30850 +38
==========================================
- Hits 24152 24129 -23
- Misses 5065 5117 +52
- Partials 1595 1604 +9
Continue to review full report at Codecov.
|
| @@ -98,3 +100,35 @@ func TestPromNativeReadPost(t *testing.T) { | |||
| h.Router.ServeHTTP(res, req) | |||
| require.Equal(t, res.Code, http.StatusMethodNotAllowed, "POST method not defined") | |||
| } | |||
|
|
|||
| func TestRooutesGet(t *testing.T) { | |||
There was a problem hiding this comment.
Ta, good catch.
| @@ -159,6 +174,9 @@ func Run(runOpts RunOptions) { | |||
| } | |||
| } | |||
|
|
|||
| namespaces := clusters.ClusterNamespaces() | |||
| logger.Info("resolved cluster namespaces", zap.Int("namespaces", len(namespaces))) | |||
There was a problem hiding this comment.
Would it be useful to list the names instead of the count?
There was a problem hiding this comment.
Sure thing.
| @@ -0,0 +1,45 @@ | |||
| listenAddress: 0.0.0.0:7201 | |||
There was a problem hiding this comment.
Is this never going to be useful for end users ? Maybe consider it moving out of integration-tests ?
This will also fix our documentation, as we'll be able to start building each service with quay.io on each push to master.