Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib] systemd: add systemd unit example #970

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Conversation

schallert
Copy link
Collaborator

Users will likely have to change this to reflect where their binaries
are located, but provides a base example.

Fixes #959.

Users will likely have to change this to reflect where their binaries
are located, but provides a base example.

Fixes #959.
@richardartoul
Copy link
Contributor

Want to put this under the integrations folder?

@richardartoul
Copy link
Contributor

Also would be helpful to link to this file from the docs

Copy link
Contributor

@richardartoul richardartoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #970 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   77.81%   77.89%   +0.07%     
==========================================
  Files         411      411              
  Lines       34437    34437              
==========================================
+ Hits        26798    26823      +25     
+ Misses       5782     5752      -30     
- Partials     1857     1862       +5
Flag Coverage Δ
#dbnode 81.47% <ø> (+0.07%) ⬆️
#m3ninx 75.25% <ø> (ø) ⬆️
#query 64.35% <ø> (+0.09%) ⬆️
#x 80.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f46fd4...3742d5f. Read the comment docs.

@schallert schallert merged commit cece4ea into master Sep 28, 2018
@schallert schallert deleted the schallert/systemd_unit branch September 28, 2018 18:30

[Service]
Type=simple
ExecStart=/usr/bin/m3dbnode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if we should include the config flag within this ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn good catch, opened #974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants