Improve M3DB session performance part 2: Dont clone IDs if they are IsNoFinalize() #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek
reviewed
Sep 29, 2018
src/dbnode/client/session.go
Outdated
| @@ -1185,7 +1185,7 @@ func (s *session) fetchTaggedAttemptWithRLock( | |||
| ) (*fetchState, error) { | |||
| // NB(prateek): we have to clone the namespace, as we cannot guarantee the lifecycle | |||
| // of the hostQueues responding is less than the lifecycle of the current method. | |||
| nsClone := s.pools.id.Clone(ns) | |||
| nsClone := s.maybeClone(ns) | |||
There was a problem hiding this comment.
lets skip the fetch path for now. the impact isn't going to be nearly as pronounced and i don't want to land it without a lot more testing.
prateek
reviewed
Sep 29, 2018
| @@ -966,8 +966,8 @@ func (s *session) writeAttemptWithRLock( | |||
| // use in the various queues. Tracking per writeAttempt isn't sufficient as | |||
| // we may enqueue multiple writeStates concurrently depending on retries | |||
| // and consistency level checks. | |||
| nsID := s.pools.id.Clone(namespace) | |||
| tsID := s.pools.id.Clone(id) | |||
| nsID := s.cloneFinalizable(namespace) | |||
There was a problem hiding this comment.
nit: also add a test cases to ensure we're doing the right thing. https://github.com/m3db/m3/blob/master/src/x/test/util.go#L30 won't be for naught
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
+ Coverage 75.53% 77.85% +2.31%
==========================================
Files 406 411 +5
Lines 34290 34473 +183
==========================================
+ Hits 25902 26840 +938
+ Misses 6492 5772 -720
+ Partials 1896 1861 -35
Continue to review full report at Codecov.
|
richardartoul
force-pushed
the
ra/sess-perf-2
branch
from
4d2fb01
to
b5d3e6f
Compare
prateek
requested changes
Sep 30, 2018
prateek
approved these changes
Sep 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.