Fix write fanouts with aggregated namespaces #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek
reviewed
Sep 30, 2018
| echo "Wait until data begins being written to remote storage for the aggregated namespace" | ||
| ATTEMPTS=10 TIMEOUT=2 retry_with_backoff \ | ||
| '[[ $(curl -sSf 0.0.0.0:9090/api/v1/query?query=database_write_tagged_success\\{namespace=\"agg\"\\} | jq -r .data.result[0].value[1]) -gt 0 ]]' | ||
|
|
There was a problem hiding this comment.
remove the docker compose down below
prateek
reviewed
Sep 30, 2018
| @@ -11,6 +11,13 @@ echo "Run m3dbnode and m3coordinator containers" | |||
| docker-compose -f ${COMPOSE_FILE} up -d dbnode01 | |||
| docker-compose -f ${COMPOSE_FILE} up -d coordinator01 | |||
|
|
|||
| # think of this as a defer func() in golang | |||
| function defer { | |||
prateek
reviewed
Sep 30, 2018
| @@ -6,9 +6,43 @@ echo "Bringing up nodes in the backgorund with docker compose, remember to run . | |||
| docker-compose -f docker-compose.yml up -d --renew-anon-volumes | |||
| echo "Nodes online" | |||
|
|
|||
| sleep 10 | |||
There was a problem hiding this comment.
drop changes to m3_stack from the pr
prateek
reviewed
Sep 30, 2018
| curl -vvvsSf -X DELETE 0.0.0.0:7201/api/v1/namespace/default |
prateek
reviewed
Sep 30, 2018
| @@ -359,7 +360,7 @@ func newDownsampler( | |||
| RulesKVStore: kvStore, | |||
| AutoMappingRules: autoMappingRules, | |||
| ClockOptions: clock.NewOptions(), | |||
| InstrumentOptions: instrumentOpts, | |||
| InstrumentOptions: instrumentOpts.SetMetricsScope(tally.NoopScope), | |||
There was a problem hiding this comment.
nit: put a reference to 992
TODO: remove after https://github.com/m3db/m3/issues/992 is fixed
prateek
reviewed
Sep 30, 2018
src/query/server/server.go
Outdated
| @@ -58,6 +58,7 @@ import ( | |||
| "github.com/m3db/m3x/pool" | |||
| xsync "github.com/m3db/m3x/sync" | |||
| xtime "github.com/m3db/m3x/time" | |||
| "github.com/uber-go/tally" | |||
There was a problem hiding this comment.
metalinter is going to complain about this
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 55.91% 77.82% +21.9%
==========================================
Files 407 411 +4
Lines 34318 34516 +198
==========================================
+ Hits 19188 26861 +7673
+ Misses 13322 5783 -7539
- Partials 1808 1872 +64
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.