Skip to content
This repository has been archived by the owner on Feb 28, 2019. It is now read-only.

Update m3x dependency to make nullLogger a pointer type #41

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Update m3x dependency to make nullLogger a pointer type #41

merged 1 commit into from
Dec 14, 2017

Conversation

xichen2020
Copy link
Contributor

cc @jeromefroe @cw9

Updating m3x dependency to make nullLogger a pointer type.

@coveralls
Copy link

coveralls commented Dec 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 49.603% when pulling bdf42f9 on xichen-pull-m3x into 4455a23 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.603% when pulling bdf42f9 on xichen-pull-m3x into 4455a23 on master.

jeromefroe
jeromefroe approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@jeromefroe jeromefroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xichen2020 xichen2020 merged commit bd1b68a into master Dec 14, 2017
@xichen2020 xichen2020 deleted the xichen-pull-m3x branch December 14, 2017 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeromefroe jeromefroe jeromefroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xichen2020 @coveralls @jeromefroe