This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
JSON marshaling of policies list #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cw9
reviewed
Jun 20, 2017
policy/staged_policy_test.go
Outdated
| false, | ||
| []Policy{ | ||
| NewPolicy(NewStoragePolicy(10*time.Second, xtime.Second, 6*time.Hour), DefaultAggregationID), | ||
| NewPolicy(NewStoragePolicy(time.Minute, xtime.Minute, 24*time.Hour), mustCompress(Lower, Upper)), |
There was a problem hiding this comment.
Can you do mustCompress(Count, Mean) to avoid having to change Lower and Upper to Min and Max later?
There was a problem hiding this comment.
Sure, sounds good.
|
|
||
| // stagedPoliciesJSON is used for marshaling and unmarshaling staged policies. | ||
| type stagedPoliciesJSON struct { | ||
| CutoverNanos int64 `json:"cutoverNanos"` |
There was a problem hiding this comment.
why not just define the json properties in the original StagedPolicies struct?
There was a problem hiding this comment.
Unfortunately JSON marshaler doesn't marshal the unexported field policies in staged policies.
|
@cw9 To persist policies list in our index. |
|
As discussed offline, we also need to store version of the policiesList |
cw9
approved these changes
Jun 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @cw9 @prateek @jeromefroe
This PR adds logic to perform JSON marshalling/unmarshaling of a list of policies.