This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Initial setup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xichen2020
reviewed
Mar 22, 2018
.excludefmt
Outdated
| (proto/) | ||
| (gen-go/) | ||
| (mocks/) | ||
| (.pb.go) |
CONTRIBUTING.md
Outdated
| Contributing | ||
| ============ | ||
|
|
||
| We'd love your help making M3DB great! |
There was a problem hiding this comment.
This is for M3DB, change or delete this file?
There was a problem hiding this comment.
This file is in a lot of repos under m3db/, like m3x m3cluster m3db, since all the repos are still under the org of m3db, I guess just leave it here for now?
There was a problem hiding this comment.
Hm on line 19 it talks about submitting issues to the m3db/m3db repo. I'd suggesting changing M3DB to M3Msg where needed. or just deleting this file.
There was a problem hiding this comment.
sure, can delete the file
LICENSE.md
Outdated
| @@ -0,0 +1,19 @@ | |||
| Copyright (c) 2016 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
Should use a 2018 license.
| - package: github.com/golang/protobuf | ||
| version: v1.0.0 | ||
| - package: github.com/gogo/protobuf | ||
| version: v1.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.