This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Add consumer server #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xichen2020
reviewed
May 29, 2018
| @@ -51,6 +54,7 @@ func NewListener(addr string, opts Options) (Listener, error) { | |||
| Listener: lis, | |||
| opts: opts, | |||
| msgPool: mPool, | |||
| m: newConsumerMetrics(opts.InstrumentOptions().MetricsScope()), | |||
There was a problem hiding this comment.
nit: newListenerMetrics?
There was a problem hiding this comment.
it's actually consumer metrics, just created at listener level so that it can be shared by all consumers
consumer/server.go
Outdated
| addr, | ||
| newHandler(opts.ConsumeFn(), opts.ConsumerOptions()), | ||
| opts.ServerOptions(), | ||
| ), nil |
There was a problem hiding this comment.
If this always returns nil, perhaps don't return an error?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I was planning to add a
MessageFnlike Kafka's interface, so users just need to pass in a lambda for processing messages, but in order to work with msgpack, it's better for us to reuse the iterator for the whole lifecycle of the consumer/connection so I changed the interface to take aConsumeFn, maybe I can change the interface to useMessageFnonce we migrated everything from msgpack to protobuf.@xichen2020