New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack environment variable should not be "must set" variable #111

Closed

hirosassa opened this issue Dec 27, 2019 · 0 comments · Fixed by #141

Collaborator

hirosassa commented Dec 27, 2019

Slack notification is not "must have feature".
If the env var is not set, workflow should run properly and notification is not launched.

https://github.com/m3dev/gokart/blob/master/gokart/run.py#L32

hirosassa mentioned this issue

add Slack error handling and remove use of deprecated API method #141

Merged

Hi-king closed this as completed in #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment