You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I really apologize for the PR (#205), and if you do not mind, please revert the PR or drop the tag.
Hashing tasks (or any classes) is a harder problem than I thought, because classes depends on some packages and the packages also.
So your workaround with version tags is very reasonable for the issue I mentioned in the PR
I think inspect.getsource can be a solution for this since we do not need serialized task but just hash values.
However, I do not have a good idea to retrieve codes recursively to reflect all the dependencies.
Anyway, the current implementation is invalid and I am sorry again for the inconvenience
The text was updated successfully, but these errors were encountered:
I found
serialized_task_definition_check
(introduced by #205) option creates different hashes if a task depends on imported object.To reproduce the bug, run this scripts many times.
I really apologize for the PR (#205), and if you do not mind, please revert the PR or drop the tag.
Hashing tasks (or any classes) is a harder problem than I thought, because classes depends on some packages and the packages also.
So your workaround with version tags is very reasonable for the issue I mentioned in the PR
I think
inspect.getsource
can be a solution for this since we do not need serialized task but just hash values.However, I do not have a good idea to retrieve codes recursively to reflect all the dependencies.
Anyway, the current implementation is invalid and I am sorry again for the inconvenience
The text was updated successfully, but these errors were encountered: