Add options to check task definition to create an output #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiro-o918
changed the title
|
@hiro-o918 Thanks great suggestions. Is it possible to apply a yapf formatter? |
|
LGTM. I'll wait for the @Hi-king review. |
|
@hiro-o918 |
hirosassa
approved these changes
May 5, 2021
| @@ -316,7 +339,7 @@ def test_add_configuration(self, mock_config: MagicMock): | |||
| self.assertEqual(True, kwargs['bool_param']) | |||
|
|
|||
| @patch('luigi.cmdline_parser.CmdlineParser.get_instance') | |||
| def test_add_cofigureation_evaluation_order(self, mock_cmdline: MagicMock): | |||
| def test_add_configuration_evaluation_order(self, mock_cmdline: MagicMock): | |||
| @@ -369,7 +392,7 @@ def test_load_index_only_dataframe(self): | |||
| task = _DummyTask() | |||
| task.load = MagicMock(return_value=pd.DataFrame(index=range(3))) | |||
|
|
|||
| # connnot load index only frame with required_columns | |||
| # cannot load index only frame with required_columns | |||
|
Cool solution! For workaround, currently we're using |
|
Thank you for your fast your reviews! 🚀 |
|
@hiro-o918 gokart 1.0.1 including your great contribution is released. Thanks again! |
hirosassa
added a commit
that referenced
this pull request
May 11, 2021
This reverts commit d5e55f4.
hirosassa
added a commit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a feature to create a hash of a task.
The hash is created by
cloudpickle.dumpsto the class object of a task.Why
Current implementation assumes that an output is determined by input parameters and requirements.
But this assumption does not work, when the implementation of a task changes.
As a results, some issues can occur.
.pklto rerun tasksmodification_time_checkcan resolve this in some aspects (I like this option).pklmust be removed as well as local development.So, adding task definition to hash resolves these issues and re-reruns tasks safely.
Discussion
cloudpickle