set default file path for make large data frame target #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-king
reviewed
Nov 29, 2020
| @@ -61,8 +61,7 @@ def __init__(self, *args, **kwargs): | |||
| self._rerun_state = self.rerun | |||
|
|
|||
| def output(self): | |||
| file_path = self.__module__.replace(".", "/") | |||
| return self.make_target(os.path.join(file_path, f"{type(self).__name__}.pkl")) | |||
| return self.make_target() | |||
|
@mski-iksm Really thank you for covering my issue. Looks great solution for that issue! |
|
@hirosassa Any comments? |
Hi-king
approved these changes
Nov 29, 2020
|
I'll make new release version after merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added default path for
make_large_data_frame_target()fix #112
@Hi-king
Please review.