-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gokart build method #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@hirosassa thx. @Hi-king @mski-iksm plz review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concerns are about overlappings between gokart.run and gokart.build
I don't think there's usually a use case for that. So, I'll write some documentation. |
_reset_register() | ||
_read_environ() | ||
_check_config() | ||
with HideLogger(verbose): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool way :)
My point is not for usage, but for developing from the point of view of the reusability. |
@vaaaaanquish cool refactoring. Merged. Thx :) |
example