Feature/implement fast load lock #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mski-iksm
requested review from
Hi-king,
e-mon,
hirosassa,
kitagry,
snowhork and
ujiuji1259
hirosassa
requested changes
Feb 25, 2022
There was a problem hiding this comment.
@mski-iksm Thanks for great contribution!
I put a few comments for documentation.
Could you also add doc here?
https://github.com/m3dev/gokart/blob/master/docs/using_task_cache_collision_lock.rst
gokart/redis_lock.py
Outdated
Comment on lines
154
to
155
| # When TargetOnKart.remove() is called, remove() must be simply wrapped with redis lock. | ||
| # https://github.com/m3dev/gokart/issues/265 |
There was a problem hiding this comment.
This should be documented, too.
kitagry
reviewed
Mar 28, 2022
kitagry
reviewed
Mar 28, 2022
|
@mski-iksm thx for cool improvement :) @hirosassa @kitagry thx for reviews! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #265
I've implemented redis lock following above issue.
Please review!