Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASY: add logging to goblin #32

Closed
3 of 5 tasks
m4b opened this issue Jul 30, 2017 · 2 comments
Closed
3 of 5 tasks

EASY: add logging to goblin #32

m4b opened this issue Jul 30, 2017 · 2 comments

Comments

@m4b
Copy link
Owner

m4b commented Jul 30, 2017

It's time to get Real Serious ™️ and add logging to goblin.

There are a number of places in goblin where things have "gone wrong", but not enough that we shouldn't parse.

Refactoring dyn to check the index of DT_NEEDED to fix a bug found while fuzzing, ref #27, we should continue parsing, but the client only receives a None, which is fine for clients, but we may also want to know why we received none, hence a warn! would be appropriate.

There are also many times when debugging, e.g., #28, I just need to see the execution state at the point of failure, which is precisely what debug! is for.

Steps

  1. add extern log
  2. add logs in various places, useful places. debug! for extremely verbose stuff, info maybe, and warn! where the binary is malformed some way, e.g., in first example.
  3. add to PE
  4. add to ELF
  5. add to mach
@m4b m4b changed the title add logging to goblin EASY: add logging to goblin Jul 30, 2017
m4b added a commit that referenced this issue Aug 5, 2017
@m4b
Copy link
Owner Author

m4b commented Aug 8, 2017

logging is in place, now can slowly add logs where appropriate to places. PE is mostly done I think, minus the exports.

@m4b m4b added this to the 0.0.12 milestone Aug 25, 2017
@m4b m4b modified the milestones: 0.0.12, 0.0.13 Oct 29, 2017
@m4b
Copy link
Owner Author

m4b commented Jan 16, 2018

Meh; this is basically done; can implement as needed, where needed, e.g., like in #64

@m4b m4b closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant