Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if an entry in the TLS callback list is the terminator before trying to load it #413

Closed

Conversation

gabrielesvelto
Copy link

This fixes issue #412.

Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a test or update a test to make sure this doesn't regress?

@gabrielesvelto
Copy link
Author

Sure, I'll try to add it.

@m4b
Copy link
Owner

m4b commented Jul 21, 2024

let me know if you have a test case ready, or if you can modify an existing one that shows this change won't add any regressions, etc. thanks!

@gabrielesvelto
Copy link
Author

let me know if you have a test case ready, or if you can modify an existing one that shows this change won't add any regressions, etc. thanks!

Yeah, I'll add a test here and provide a fix for issue #412 too later this year. I've been caught up in other stuff but I'll try to come back to this ASAP.

@m4b
Copy link
Owner

m4b commented Jul 21, 2024

@gabrielesvelto no worries, just doing some triage this weekend/poking people :)

@m4b
Copy link
Owner

m4b commented Oct 26, 2024

@gabrielesvelto thank you for this patch; it turns out this was re-discovered and fixed in another patch #425 fixing some recent tls stuff breaking on rust produced binaries, but thank you for your contribution and sorry we didn't merge it earlier :)

@m4b m4b closed this Oct 26, 2024
@gabrielesvelto
Copy link
Author

np, glad it's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants