-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Copyright notices. #1
Add Copyright notices. #1
Conversation
This will definitely need some more discussion. When it comes to copyright we follow the same rules and guidelines as the main Godot project. We've long been discussing, and should have taken action on, enforcing the standard copyright message on each file as the main Godot project does. So something like:
It definitely doesn't make sense to stray away from this for trivial files like From what I understand authors of contributions have automatic copyright over their contributions but agree to have those fall under the MIT license as well. What I think the main project doesn't do well (understandably due to its size) and what I don't mind seeing changed here, is attribution to who submitted the original code of larger systems. So having the standard copyright message followed by a:
in the |
e9d2c0f
to
7b7bb3a
Compare
@BastiaanOlij I totally agree, that a standard copyright header is the best way to move forward. Updated the PR based on your comment. Would this be acceptable for you? Independently of this: wouldn't it make sense to rename the Github organization to GodotXR? AFAIR Github automatically creates a redirect from the old name to the new one. |
Yeah that looks good, only problem we'll need to think about is that if we want to make this part of the CI check, we need a separate section for the attribution. Or we just need to start being mindful of it ourselves. @m4gr3d I think it would be good to make a separate PR introducing the copyright header on other files where we think this would be a good idea? We also need to change the LICENSE file in the root to match this. It still refers to myself and Gergely holding primary copyright, which came from the early beginnings of the loader. we probably need to check the contributors.md file as well to make sure it is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move forward with this, I like the changes kisg made. For now we'll manually include the license header.
I think we should make sure the LICENSE in the root matches too but we can fix that on the main repo.
And we'll need to see about adding this to other files in due course.
7c4abae
to
8b356af
Compare
I cherry-picked the changes into the branch! |
No description provided.