Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow single commit so that working tree changes can be included. #4

Merged
merged 4 commits into from Feb 5, 2016
Merged

Allow single commit so that working tree changes can be included. #4

merged 4 commits into from Feb 5, 2016

Conversation

dayyan
Copy link
Contributor

@dayyan dayyan commented Feb 19, 2015

It is assumed when providing one commit, the previous commit and the provided commit were to be used.

rubocop-git should behave more like git, where providing one commit means comparing your changes to that commit.

@dayyan
Copy link
Contributor Author

dayyan commented Apr 14, 2015

@dayyan dayyan closed this May 21, 2015
@dayyan dayyan reopened this Aug 26, 2015
@tylerwillingham
Copy link

@jrochkind
Copy link

I am interested in this too. I want to be able to diff working tree to master, for instance. Any way to do this?

@torrocus
Copy link

+1

@jrochkind
Copy link

Is this repo maintained by anyone? Should we fork it?

@jrochkind
Copy link

Hey @m4i, if don't hear back from you, I'm going to make a fork so I can get all these PR's, because I want them. (Esp this one and #10). @dayyan , you in?

@dayyan
Copy link
Contributor Author

dayyan commented Jan 21, 2016

Sounds good man.
On Wed, Jan 20, 2016 at 14:16 Jonathan Rochkind notifications@github.com
wrote:

Hey @m4i https://github.com/m4i, if don't hear back from you, I'm going
to make a fork so I can get all these PR's, because I want them. (Esp this
one and #10 #10). @dayyan
https://github.com/dayyan , you in?


Reply to this email directly or view it on GitHub
#4 (comment).

@jrochkind jrochkind mentioned this pull request Jan 26, 2016
@jrochkind
Copy link

I want to diff current working copy against master; there's no way to do that without this patch.

Pretty please @m4i?

@m4i
Copy link
Owner

m4i commented Jan 26, 2016

Sorry for the late reply.
l'm going to check it by the weekend, please wait for a little while longer.

m4i added a commit that referenced this pull request Feb 5, 2016
Allow single commit so that working tree changes can be included.
@m4i m4i merged commit 8d6d002 into m4i:master Feb 5, 2016
@jrochkind
Copy link

Thank you! Do a gem release that includes the recent merges?

@m4i
Copy link
Owner

m4i commented Feb 5, 2016

Thank you for pull request and comments.
I have released 0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants