Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscraper not writing output to file #5

Closed
njmulsqb opened this issue Oct 4, 2020 · 3 comments
Closed

Subscraper not writing output to file #5

njmulsqb opened this issue Oct 4, 2020 · 3 comments

Comments

@njmulsqb
Copy link

njmulsqb commented Oct 4, 2020

I am using subscraper on Parrot OS, it runs well and also says that subdomains written to output.txt, the file gets created but its always empty. any solution? I ve tried using sudo too

@m8sec
Copy link
Owner

m8sec commented Oct 13, 2020

Hi @najum98,

Does this happen every time?

How is the program exiting? running to completion or ctrl+c

Once valid subdomains are identified the SubReporter class is responsible for further output & reporting. This is performed in a separate thread, based of queues. More importantly, the report file should be opened during initialization of the class and closed before exiting. If the program exits before the file is properly close, this may result in a blank file.

I am overdue to take another look at the code and add some updates, so I can investigate further. Thank you for your help!

-m8r0wn

@artgonline
Copy link
Contributor

Hi @m8r0wn, I had similar issue, but the reason was masked by the error in subscraper/subscraper/modules/dns_brute.py file, where isAlive is used instead of is_alive. Then subdomain bruteforcing would crash, but everything else continues to run. The results at the end wouldn't write though. Lemme create a PR for it.

m8sec added a commit that referenced this issue Dec 14, 2020
Fix incorrect threading method
@m8sec
Copy link
Owner

m8sec commented Dec 14, 2020

@artgonline,

Awesome, thank you for your help on this. PR made and can close this issue

@m8sec m8sec closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants