Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLA Management instructions #9

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Conversation

rosogon
Copy link
Contributor

@rosogon rosogon commented Jun 18, 2018

@cjdcordeiro , @FranCarpio : please, have a look to make sure it is congruent.

Copy link
Contributor

@fcarp10 fcarp10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok for now, but we should updated it, when the GUI works with default agreement.


.. code-block:: bash

{
"name": "an-agreement-name",
"name": "your-service-name-here",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this name is a metadata attribute, respective to the resource itself, so it shouldn't be the name of the service

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simple workaround to make an agreement specific to a service (only for IT-1!). If the name is arbitrary, it will be used as the default agreement. @FranCarpio : can you confirm this?

"details":{
"id": "2018-000234",
"type": "agreement",
"name": "an-agreement-name",
"name": "your-service-name-here",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this name used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To give a descriptive name to an agreement. It must match the outer name.

"guarantees": [
{
"name": "TestGuarantee",
"constraint": "[execution_time] < 100"
"name": "*",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what name is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guarantee name matches the name of the operation, but to make it simpler to have a running evaluation for any kind of service, I decided to use that special name to flag this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 3 "name" attributes are confusing but if that's how it works , for now it's ok


.. code-block:: bash

curl -X POST -d @agreement.json -H"Content-type:application/json" -H"slipstream-authn-info: super ADMIN" $CIMI_URL/api/agreement

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this documentation mean for the user? if so, then "super ADMIN" should not be used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is documentation for the person installing the agent, not a normal user.

If cannot use the pwd, how does the user know how the agreement can be created?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"super ADMIN" is just for administrators and temporary. If this is meant for the person installing the agent, then the user already has an account he can use

@rosogon
Copy link
Contributor Author

rosogon commented Jun 22, 2018

@cjdcordeiro , @FranCarpio : This instructions are intended to add the agreements by the admin user, not by a normal user. Then, the normal user, when using the GUI, can run a service without worrying about agreements.

The SLA Mgmt has been slightly modified to allow one agreement to cover different types of services. This is a workaround, because it cannot be this way. For IT-2, a template will be associated to the service, and an agreement will be generated for each service instance.

@rosogon
Copy link
Contributor Author

rosogon commented Jun 25, 2018

Hi @cjdcordeiro : I updated the instructions.

  • The default agreement have a name of "*". This is used by the GUI to search an agreement to use.
  • To use a different agreement for a service, rename the agreement name with the service name, as explained.
  • The auth header is removed, but the rest of the instructions should be checked, I guess.

@cjdcordeiro cjdcordeiro merged commit 2cff02b into master Apr 5, 2019
@cjdcordeiro cjdcordeiro deleted the rosogon-patch-1 branch April 5, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants