Feat: global nav #36
Merged
Feat: global nav #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jared-dickman
commented
Feb 23, 2024
.gitignore
Outdated
| @@ -89,7 +89,6 @@ out | |||
|
|
|||
| # Nuxt.js build / generate output | |||
| .nuxt | |||
| dist | |||
There was a problem hiding this comment.
todo: this is for development only
jared-dickman
commented
Feb 23, 2024
| @@ -18,7 +15,7 @@ const meta: Meta<typeof Avatar> = { | |||
| args: { | |||
| alt: 'User Avatar', | |||
| gap: 4, | |||
| icon: <Icon icon={faUser} />, | |||
There was a problem hiding this comment.
with the removal of font awesome, and the pending of a new Icon component, all story icons have temporarily been replaced with a generic icon [mp logo]
jared-dickman
commented
Feb 23, 2024
| @@ -0,0 +1,21 @@ | |||
| import { getInitials } from './utils' | |||
There was a problem hiding this comment.
TD item to get this working
jared-dickman
commented
Feb 23, 2024
| @@ -0,0 +1,3 @@ | |||
| .u-display-none { | |||
There was a problem hiding this comment.
consider how utils might be exported downstream from the aquarium
… into feat/global-nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
mainSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)
Figma Exporation