Adds conformsToProtocol forwarding to MPAppDelegateProxy #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einsteinx2
pushed a commit
that referenced
this pull request
May 16, 2022
einsteinx2
pushed a commit
that referenced
this pull request
May 17, 2022
mparticle-automation
added a commit
that referenced
this pull request
May 17, 2022
# [8.8.0](v8.7.0...v8.8.0) (2022-05-17) ### Bug Fixes * Fix Dereferenced Garbage Pointer ([#148](#148)) ([d2c58e1](d2c58e1)) * property memory annotations ([#146](#146)) ([c95ddf6](c95ddf6)) * update active kits header ([#147](#147)) ([d196723](d196723)) ### Features * add conformsToProtocol forwarding to MPAppDelegateProxy ([#144](#144)) ([40e517a](40e517a)) * add support for client side rules ([#151](#151)) ([6a93096](6a93096))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an implementation of
conformsToProtocol:toMPAppDelegateProxythat bubbles up protocol implementations from the base AppDelegate. Issue is described in #143.Had to add an extra singleton in order to get the original app delegate types. If anyone can think of a better way, input is extremely welcome.
Testing Plan
Manually smoke tested in our setup, and unit tested. Should be low-to-no impact for other integrations, but unknown.
Master Issue
Implementation as described in #143