Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and Restore The Selected Snippet #38

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

cwarden
Copy link
Contributor

@cwarden cwarden commented Mar 16, 2023

Store the selected snippet as along with the selected folder, and restore when starting nap.

Store the selected snippet as along with the selected folder, and
restore when starting nap.
@cwarden cwarden mentioned this pull request Mar 16, 2023
@jolheiser
Copy link
Collaborator

I wonder if it would be better to save the snippet name? This way things like #33 wouldn't accidentally break this state? e.g. if scanning changes the number of snippets, this index could be off.

On a side note, I suppose that would also break the currentFolder index...so maybe I can change both in #33 and this can be used until then?

Thoughts?

@cwarden
Copy link
Contributor Author

cwarden commented Mar 16, 2023

I don't feel strongly about it either way. If the state fails to restore occasionally when new files are added or when files are renamed outside of nap, it's not a big deal.

@jolheiser jolheiser merged commit 516b48f into maaslalani:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants