some base level additions and minor cleanup and window title bar drag ability #498

ginkoblongata · 2020-06-28T18:16:53Z

No description provided.

ginkoblongata · 2020-06-28T18:24:26Z

This PR represents commonality sliced out of the PR of the ScrollPanel stuff.

Once this makes it through, I'll put in a PR for the ImageComponent, then another PR for the SplitPanel.

I think then the ScrolPanel PR will be hopefully on topic specifically enough.

Thanks!

ginkoblongata · 2020-06-28T18:31:54Z

src/main/java/com/googlecode/lanterna/gui2/AbstractBasePane.java

@@ -44,6 +45,8 @@
    private boolean strictFocusChange;
    private boolean enableDirectionBasedMovements;
    private Theme theme;
+
+    private Interactable mouseDownForDrag = null;


This makes it so that the component which experienced the mouse down is the component which the mouse drags get routed to.

…dows() with stable ordering of windows

ginkoblongata · 2020-06-28T18:45:39Z

src/main/java/com/googlecode/lanterna/gui2/AbstractWindow.java

        if(globalPosition == null || lastKnownPosition == null) {
            return null;
        }
        return globalPosition.withRelative(
                -lastKnownPosition.getColumn() - contentOffset.getColumn(),
                -lastKnownPosition.getRow() - contentOffset.getRow());
    }
+
+    @Override


Used by MultiWindowTextGUI.

ginkoblongata · 2020-06-28T18:46:14Z

src/main/java/com/googlecode/lanterna/gui2/ComboBox.java

@@ -558,15 +557,15 @@ private Result handleEditableCBKeyStroke(KeyStroke keyStroke) {
        public PopupWindow() {
            setHints(Arrays.asList(
                    Hint.NO_FOCUS,
-                    Hint.FIXED_POSITION));
+                    Hint.FIXED_POSITION,
+                    Hint.MENU_POPUP));


Used by MultiWindowTextGUI.

ginkoblongata · 2020-06-28T18:51:16Z

src/main/java/com/googlecode/lanterna/gui2/MultiWindowTextGUI.java

@@ -46,12 +46,17 @@
    private final WindowManager windowManager;
    private final BasePane backgroundPane;
    private final List<Window> windows;
+    private final List<Window> stableOrderingOfWindows;


The purpose of the list stableOrderingOfWindows vs the windows list is that the WindowManager would prefer to have the same ordering everytime.

For example a 2x2 grid style window manager would like to arrange the windows in position and size and have those remain regardless of which window is active.
Prior to this change, the windows are coming through in different order because the active window is put to the front of the list, this would force most window managers to do this bookkeeping work which seems to involve overriding multiple methods.

So essentially z-order is what the existing windows list does, but most window managers would probably want access to z-ordering only secondarily to their primary ordering for layout purposes.

Ok, but I think in that case rather than having two lists, we should create a WindowList class or something like that, which can encapsulate the z-index and the stable index. It would make the code interacting with the list(s) of windows in here much easier.

I've added a WindowList class.

mabe02 · 2020-07-11T11:07:57Z

src/main/java/com/googlecode/lanterna/gui2/Window.java

@@ -180,6 +181,13 @@ public String toString() {
    @Override
    void invalidate();

+
+    default TerminalRectangle getBounds() {


Need to add Javadoc to this one and the two below

I've updated with some javadocs.

mabe02 · 2020-07-11T11:08:36Z

src/main/java/com/googlecode/lanterna/gui2/Window.java

@@ -390,7 +398,11 @@ public String toString() {
     * @return The global coordinates expressed as local coordinates
     */
    @Override
+    @Deprecated


Add a @deprecated Javadoc note for this and explain what to use instead

I've updated with some javadocs.

mabe02 · 2020-07-11T11:10:24Z

Looks like we can merge this with a few tweaks. For some of the bigger changes in the other PR, I think we want to target master (3.2). But let's see, one PR at a time.

ginkoblongata · 2020-07-11T19:09:43Z

Ok, I think this is ready for next round. Once this is through, I think I can slice out the ImageComponent with pretty much cleanly for another PR.

avl42 · 2020-07-12T16:57:19Z

Since which Java version can keyword "default" be used in that context? ginkoblongata <notifications@github.com> schrieb am Sa., 11. Juli 2020, 20:48:

…

***@***.**** commented on this pull request. ------------------------------ In src/main/java/com/googlecode/lanterna/gui2/Window.java <#498 (comment)>: > @@ -180,6 +181,13 @@ public String toString() { @OverRide void invalidate(); + + default TerminalRectangle getBounds() { I've updated with some javadocs. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#498 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIDBMUXHQV5HCPNUCBOGOTR3CXWDANCNFSM4OKURVAA> .

jrb0001 · 2020-07-12T17:02:16Z

Java 8 introduced the default keyword on interface methods.

ginkoblongata · 2020-07-12T22:43:34Z

Yes, also, by adding to the interface like that with the 'default' it makes it so that existing implementations of the interface can continue to work as is.
I tend to use that feature sparingly but it works out well for that.

I am hoping this PR will make it in.
I have a bunch of thoughts of potential rearrangement type breaking changes for Lanterna but I'd like to keep with the non breaking addition type stuff for now before focusing on that discussion. I think I've been leaning towards brevity for these but could go into more full context details.

mabe02 · 2020-07-25T04:43:42Z

Alright, that is now merged into 3.1

doing some base level additions and minor cleanup

fdf0151

ginkoblongata changed the base branch from master to release/3.1 June 28, 2020 18:25

ginkoblongata commented Jun 28, 2020

View reviewed changes

make windows draggable by title area, invoke WindowManager.prepareWin…

257bc8f

…dows() with stable ordering of windows

ginkoblongata commented Jun 28, 2020

View reviewed changes

ginkoblongata changed the title ~~doing some base level additions and minor cleanup~~ doing some base level additions and minor cleanup, and window title bar drag ability Jun 28, 2020

ginkoblongata changed the title ~~doing some base level additions and minor cleanup, and window title bar drag ability~~ some base level additions and minor cleanup and window title bar drag ability Jun 28, 2020

mabe02 reviewed Jul 11, 2020

View reviewed changes

ginkoblongata added 3 commits July 11, 2020 13:05

created WindowList

5a204a0

cleanup javadocs

3198f1c

javadoc cleanup

5398bc5

mabe02 merged commit 2b7c23d into mabe02:release/3.1 Jul 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

some base level additions and minor cleanup and window title bar drag ability #498

some base level additions and minor cleanup and window title bar drag ability #498

ginkoblongata commented Jun 28, 2020

ginkoblongata commented Jun 28, 2020

ginkoblongata Jun 28, 2020

ginkoblongata Jun 28, 2020

ginkoblongata Jun 28, 2020

ginkoblongata Jun 28, 2020

mabe02 Jul 11, 2020

ginkoblongata Jul 11, 2020

mabe02 Jul 11, 2020

ginkoblongata Jul 11, 2020

mabe02 Jul 11, 2020 •

edited

Loading

ginkoblongata Jul 11, 2020

mabe02 commented Jul 11, 2020 •

edited

Loading

ginkoblongata commented Jul 11, 2020 •

edited

Loading

avl42 commented Jul 12, 2020 via email

jrb0001 commented Jul 12, 2020

ginkoblongata commented Jul 12, 2020

mabe02 commented Jul 25, 2020

some base level additions and minor cleanup and window title bar drag ability #498

some base level additions and minor cleanup and window title bar drag ability #498

Conversation

ginkoblongata commented Jun 28, 2020

ginkoblongata commented Jun 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mabe02 Jul 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mabe02 commented Jul 11, 2020 • edited Loading

ginkoblongata commented Jul 11, 2020 • edited Loading

avl42 commented Jul 12, 2020 via email

jrb0001 commented Jul 12, 2020

ginkoblongata commented Jul 12, 2020

mabe02 commented Jul 25, 2020

mabe02 Jul 11, 2020 •

edited

Loading

mabe02 commented Jul 11, 2020 •

edited

Loading

ginkoblongata commented Jul 11, 2020 •

edited

Loading