New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 multi-way CROSS JOINs aren't being planned correctly #1438

Open

3 tasks

joocer opened this issue Feb 11, 2024 · 1 comment

Open

3 tasks

🪲 multi-way CROSS JOINs aren't being planned correctly #1438

joocer opened this issue Feb 11, 2024 · 1 comment

Labels

Bug 🪲 High Priority 1️⃣

Contributor

joocer commented Feb 11, 2024 •

edited

Loading

issue starts in the logical planner - line 282
ensure predicates are being pushed into CROSS JOINs
write a JOIN fuzzer (we have a single table query fuzzer, lets fuzz JOINs too)

joocer added Bug 🪲 High Priority 1️⃣ labels

Contributor Author

joocer commented Feb 11, 2024

This appears to be a major factor in some of the TPCH test queries failing.

Need a way to

handle n-way cross joins
decide how to convert cross joins to inner joins

joocer added this to the TPH-C successful responses milestone

joocer added a commit that referenced this issue


          Merge pull request #1446 from mabel-dev/#1438/1

65acae9

#1438/1

joocer removed this from the TPH-C successful responses milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment