Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1038 #1053

Merged
merged 2 commits into from
May 27, 2023
Merged

#1038 #1053

merged 2 commits into from
May 27, 2023

Conversation

joocer
Copy link
Contributor

@joocer joocer commented May 27, 2023

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #<issue_number_goes_here>

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #1053 (82cc0cd) into main (548fb96) will increase coverage by 0.01%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   91.83%   91.84%   +0.01%     
==========================================
  Files         203      205       +2     
  Lines        8645     8674      +29     
==========================================
+ Hits         7939     7967      +28     
- Misses        706      707       +1     
Impacted Files Coverage Δ
tests/misc/test_fuzzy_search.py 100.00% <ø> (ø)
opteryx/connectors/sql_connector.py 97.05% <80.00%> (-2.95%) ⬇️
opteryx/utils/__init__.py 71.79% <100.00%> (ø)
opteryx/version.py 100.00% <100.00%> (ø)
tests/storage/test_sql_sqlite copy.py 100.00% <100.00%> (ø)
tests/storage/test_sqlalchemy.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ghost
Copy link

ghost commented May 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
23.9% 23.9% Duplication

@joocer joocer merged commit 348583f into main May 27, 2023
24 of 28 checks passed
@joocer joocer deleted the #1038 branch May 27, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant