Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX/#169 #210

Merged
merged 1 commit into from
Jun 18, 2022
Merged

FIX/#169 #210

merged 1 commit into from
Jun 18, 2022

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Jun 18, 2022

No description provided.

@ghost
Copy link

ghost commented Jun 18, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #210 (66a976f) into FIX/#199 (f5d4238) will increase coverage by 2.62%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           FIX/#199     #210      +/-   ##
============================================
+ Coverage     90.28%   92.90%   +2.62%     
============================================
  Files            75       91      +16     
  Lines          2831     3919    +1088     
============================================
+ Hits           2556     3641    +1085     
- Misses          275      278       +3     
Impacted Files Coverage Δ
...pteryx/engine/planner/operations/selection_node.py 89.83% <ø> (+0.01%) ⬆️
opteryx/engine/query_statistics.py 93.61% <0.00%> (-3.05%) ⬇️
...teryx/engine/planner/operations/cross_join_node.py 94.18% <0.00%> (-0.94%) ⬇️
opteryx/exceptions.py 100.00% <0.00%> (ø)
opteryx/engine/attribute_types.py 100.00% <0.00%> (ø)
tests/sql_battery/test_battery_shape.py 100.00% <0.00%> (ø)
opteryx/engine/planner/operations/__init__.py 100.00% <0.00%> (ø)
opteryx/third_party/distogram/__init__.py 100.00% <0.00%> (ø)
...teryx/third_party/distogram/tests/test_count_at.py 100.00% <0.00%> (ø)
opteryx/third_party/abctree/__init__.py 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d4238...66a976f. Read the comment docs.

@joocer joocer merged commit 2ecf32a into FIX/#199 Jun 18, 2022
@joocer joocer deleted the FIX/#169 branch June 18, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant