Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of URLs with semicolons #322

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Conversation

macbre
Copy link
Owner

@macbre macbre commented Jun 14, 2021

Resolves #280 // see reworkcss/css#137


$ echo "@import url('https://fonts.googleapis.com/css2?family=Montserrat:wght@400;600&display=swap'); body {}" | DEBUG=* ./bin/analyze-css.js -
  analyze-css:bin analyze-css v0.13.0 +0ms
...
  analyze-css:parser Going to parse 0.10 kB of CSS +0ms
  analyze-css:parser CSS parsed +1ms
  analyze-css {"type":"import","import":"url('https://fonts.googleapis.com/css2?family=Montserrat:wght@400","position":{"start":{"line":1,"column":1},"end":{"line":1,"column":75}}} +17ms
  analyze-css {"type":"rule","selectors":["600&display=swap'); body"],"declarations":[],"position":{"start":{"line":1,"column":75},"end":{"line":1,"column":102}}} +0ms
  analyze-css:bin Exiting with exit code #1 +21ms
Error: 600&display=swap'); body is an invalid expression

@macbre macbre added the bug label Jun 14, 2021
@macbre macbre added this to the v0.13 milestone Jun 14, 2021
@macbre macbre marked this pull request as ready for review June 14, 2021 15:24
@macbre macbre enabled auto-merge June 14, 2021 15:26
@macbre macbre disabled auto-merge June 14, 2021 15:28
@macbre macbre merged commit d0d9c96 into devel Jun 14, 2021
@macbre macbre deleted the fix/urls-with-semicolons branch June 14, 2021 15:28
@coveralls
Copy link

coveralls commented Jun 14, 2021

Pull Request Test Coverage Report for Build 936294124

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 935680240: 0.0%
Covered Lines: 521
Relevant Lines: 521

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 21, 2024

Pull Request Test Coverage Report for Build 936298801

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 935680240: 0.0%
Covered Lines: 521
Relevant Lines: 521

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on @import rule with url containing semicolon
2 participants