Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Cordova 3.x #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

arun289
Copy link

@arun289 arun289 commented Sep 30, 2013

Hi, your video plugin is awesome. It solved a big problem for me. I had to modify the code to make it work on the Cordova 3.x version as the plug in architecture seems to have changed. I forked the project and added the new source code. Please do pull it in the main repo if you feel it might be useful.

This is my first contribution in open source and in Github. Do let me know if there is any problems with the format or coding standards.

Regards,
Arun

@macdonst
Copy link
Owner

macdonst commented Oct 6, 2013

Thanks, I haven't had a chance to look at this yet but I'll get to it soon.

@theamoeba
Copy link

Thanks arun289 - I'm using this for my app currently in development and it works really well. The only issue I have run into is that when you click the back button in the video player (the one on the top left) it takes me to the android media manager instead of back to my app. I can go back to the app when using the android back arrow (bottom left). Is it possible to remove the top back button or change it to go back to my app?

@arun289
Copy link
Author

arun289 commented Oct 17, 2013

Glad to know that it is useful. I will look into that issue this weekend.

Regards,
Arun

On Wed, Oct 16, 2013 at 3:48 PM, Jonathan Wagener
notifications@github.comwrote:

Thanks arun289 - I'm using this for my app currently in development and it
works really well. The only issue I have run into is that when you click
the back button in the video player (the one on the top left) it takes me
to the android media manager instead of back to my app. I can go back to
the app when using the android back arrow (bottom left). Is it possible to
remove the top back button or change it to go back to my app?


Reply to this email directly or view it on GitHubhttps://github.com//pull/22#issuecomment-26406694
.

Arun Venkataswamy
http://wondroussky.blogspot.in/
http://wondrouscode.blogspot.in/

"கற்றது கைமண் அளவு, கல்லாதது உலகளவு" - ஔவையார்
Known is a drop, Unknown is an ocean

@tdurand
Copy link

tdurand commented Oct 24, 2013

I've adapted your code to be able to install it with the CLI: https://github.com/tdurand/videoplayer-phonegap3

@ShawnAukstak
Copy link

Thanks Tdurand. I was able to add your version using your url with the CLI. Does the trick!

The one issue I had was that instead of using window.plugins.videoPlayer.play(), I had to use window.videoPlayer.play().

@tdurand
Copy link

tdurand commented Nov 10, 2013

Ah yes, in the plugin.xml it export the namespace with window.videoPlayer : https://github.com/tdurand/videoplayer-phonegap3/blob/master/plugin.xml#L13 ..

@sambrucejoseph
Copy link

But for me it plays using window.plugins.videoPlayer.play()

@sjamaan
Copy link

sjamaan commented Jul 17, 2014

This plugin works well for me as well. However, window.plugins.videoPlayer didn't work for me (probably because I'm using Cordova 3.4.0?), I had to use the following:

var videoPlayer = window.cordova.require('org.apache.cordova.videoplayer.VideoPlayer');
videoPlayer.play('file:///android_asset/blabla.mp4');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants