-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Cordova 3.x #22
base: master
Are you sure you want to change the base?
Conversation
Thanks, I haven't had a chance to look at this yet but I'll get to it soon. |
Thanks arun289 - I'm using this for my app currently in development and it works really well. The only issue I have run into is that when you click the back button in the video player (the one on the top left) it takes me to the android media manager instead of back to my app. I can go back to the app when using the android back arrow (bottom left). Is it possible to remove the top back button or change it to go back to my app? |
Glad to know that it is useful. I will look into that issue this weekend. Regards, On Wed, Oct 16, 2013 at 3:48 PM, Jonathan Wagener
Arun Venkataswamy "கற்றது கைமண் அளவு, கல்லாதது உலகளவு" - ஔவையார் |
I've adapted your code to be able to install it with the CLI: https://github.com/tdurand/videoplayer-phonegap3 |
Thanks Tdurand. I was able to add your version using your url with the CLI. Does the trick! The one issue I had was that instead of using window.plugins.videoPlayer.play(), I had to use window.videoPlayer.play(). |
Ah yes, in the plugin.xml it export the namespace with window.videoPlayer : https://github.com/tdurand/videoplayer-phonegap3/blob/master/plugin.xml#L13 .. |
But for me it plays using window.plugins.videoPlayer.play() |
This plugin works well for me as well. However, var videoPlayer = window.cordova.require('org.apache.cordova.videoplayer.VideoPlayer');
videoPlayer.play('file:///android_asset/blabla.mp4'); |
Hi, your video plugin is awesome. It solved a big problem for me. I had to modify the code to make it work on the Cordova 3.x version as the plug in architecture seems to have changed. I forked the project and added the new source code. Please do pull it in the main repo if you feel it might be useful.
This is my first contribution in open source and in Github. Do let me know if there is any problems with the format or coding standards.
Regards,
Arun