Noetic/Python3 compatibility #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
approved these changes
Jun 28, 2020
|
@machinekoder, could you please merge this and prepare a release for ROS Noetic? We depend on this package in MoveIt. Thanks. |
23 tasks
8 tasks
|
Thank you. I'll prepare the noetic release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the current master,
ros_pytestinstalls itsros_pytest_runnerby calling CMake'sinstall()function. ROS documentation for Catkin mentions that the recommended way to install Python scripts is by usingcatkin_install_python: http://docs.ros.org/melodic/api/catkin/html/howto/format2/installing_python.html. This allows Catkin to rewrite shebangs, for instance.Another thing that should be performed for better Python 3 compatibility is to add conditional dependencies in package.xml: http://wiki.ros.org/UsingPython3/SourceCodeChanges
This P/R contains both of these changes.