Skip to content

Commit

Permalink
Bundle PHP shared libraries just before stripping the PHP binary
Browse files Browse the repository at this point in the history
Because after stripping, symbols get removed and ldd command might
not work properly.
  • Loading branch information
machitgarha committed Apr 5, 2022
1 parent f0a6a11 commit 6f8d792
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions build-aux/appimage/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ buildPhp() {
cp ./php.ini-development "$iniPath"
customizePhpIni "$iniPath"

echoSection "Bundling PHP shared libs..."
bundlePhpSharedLibraries "$appDir"

echoSection "Cleaning up..."
minimizePhpInstallationSize "$installationPrefix"

Expand Down Expand Up @@ -232,9 +235,6 @@ if [ "$skipPhpBuild" != true ]; then

echoSection "Building PHP..."
buildPhp "$phpSourcePath" "$phpInstallationPath"

echoSection "Bundling PHP shared libs..."
bundlePhpSharedLibraries "$appDir"
fi

echoSection "Copying Parvaj root to AppDir..."
Expand Down
2 changes: 1 addition & 1 deletion src/Console/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class Application extends \Symfony\Component\Console\Application
{
public const NAME = "Parvaj";
public const VERSION = "0.3.2-rc.1";
public const VERSION = "0.3.2-rc.2";

public function __construct()
{
Expand Down

0 comments on commit 6f8d792

Please sign in to comment.