Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing Logos2 #365

Merged
merged 9 commits into from
Feb 6, 2024
Merged

Releasing Logos2 #365

merged 9 commits into from
Feb 6, 2024

Conversation

jeertmans
Copy link
Collaborator

After months of waiting for a response from @maciejhirsz, regarding the access to publishing to crates.io, I think it is better to move on and publish a new crate, logos2 (and related).

The libraries' name is the same, but crates have a 2 appended at the end.

This will allow to community to continue working on Logos, and publishing new releases when possible.

After months of waiting for a response from @maciejhirsz, regarding the access to publishing to crates.io, I think it is better to move on and publish a new crate, logos2 (and related).

The libraries' name is the same, but crates have a `2` appended at the end. 

This will allow to community to continue working on Logos, and publishing new releases when possible.
@jeertmans jeertmans added the meta label Feb 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96353f2) 19.97% compared to head (e7e0a11) 20.78%.

❗ Current head e7e0a11 differs from pull request most recent head 6bdee19. Consider uploading reports for the commit 6bdee19 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   19.97%   20.78%   +0.80%     
==========================================
  Files          34       32       -2     
  Lines        2138     2074      -64     
==========================================
+ Hits          427      431       +4     
+ Misses       1711     1643      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 6, 2024

Benchmark results:

group                                         before                                 changes
-----                                         ------                                 -------
count_ok/identifiers                          1.00   846.5±12.85ns   877.6 MB/sec    1.00   844.9±48.72ns   879.3 MB/sec
count_ok/keywords_operators_and_punctators    1.00      2.6±0.04µs   792.6 MB/sec    1.05      2.7±0.02µs   755.7 MB/sec
count_ok/strings                              1.00    727.8±4.73ns  1141.3 MB/sec    1.02    741.2±5.59ns  1120.6 MB/sec
iterate/identifiers                           1.01   862.6±17.25ns   861.2 MB/sec    1.00   858.0±15.55ns   865.9 MB/sec
iterate/keywords_operators_and_punctators     1.00      2.6±0.05µs   788.7 MB/sec    1.02      2.6±0.06µs   770.5 MB/sec
iterate/strings                               1.00   706.6±62.73ns  1175.5 MB/sec    1.00   703.8±30.24ns  1180.2 MB/sec

@jeertmans jeertmans merged commit 71d1f10 into master Feb 6, 2024
18 of 19 checks passed
@jeertmans jeertmans deleted the logos2 branch February 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants