Add canvasColor to MacosThemeData and apply it to Scaffold #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GroovinChip
added a commit
that referenced
this pull request
May 26, 2021
* First pass at BackButton. Requires a rework in the vein of PushButton. See the TODO for more details. * Progress towards properly animating the BackButton * Animation working * Use correct color for dark mode tap * Remove material imports * Add debug props * Add missing traling comma and default back action * First pass at IconButton * Improve sizing * Add documentation * Fix localizations not being returned & add VisualDensity to MacosThemeData * Revert main.dart thememode * Bump version and CHANGELOG.md * minor tweak * const constructor * add DefaultWidgetsLocalizations.delegate * macro docs * export util in library rather than macos_ui * changes that were supposed to be in previous commit * Add in some required changes that got lost * Allow passing an Icon widget to IconButton This alllows developers to have better control over colors. The color property has also been renamed to backgroundColor * Update version, changelog, remove unused foregroundColor * Update version, changelog, remove unused foregroundColor * update lock file * Update docs * 0.2.2. Macos colors (#113) * Rename colors.dart * Add and export macos_colors.dart * Update version, changelog * Add documentation * Add canvasColor to MacosThemeData and apply it to Scaffold (#116) * Update github templates (#112) * Update github templates * Fixed issues * Update feature_request.md * Fix text field (#118) * Fix text field * Bump version & update changelog Co-authored-by: GroovinChip <groovinchip@gmail.com> * Add prefixes to overlapping widgets/classes (#117) * Add prefixes to overlapping widgets/classes, update version/changelog * Update widget names in readme * run dartfmt on tooltip.dart * run dartfmt on macos_theme.dart * Add missing backtick * code_metrics_reporter (#119) * Add a missing comma * Add code metrics step * Try to fix failing pub get * Break out steps a little further * Do checkout first Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
GroovinChip
added a commit
that referenced
this pull request
Jun 1, 2021
* First pass at BackButton. Requires a rework in the vein of PushButton. See the TODO for more details. * Progress towards properly animating the BackButton * Animation working * Use correct color for dark mode tap * Remove material imports * Add debug props * Add missing traling comma and default back action * First pass at IconButton * Improve sizing * Add documentation * Fix localizations not being returned & add VisualDensity to MacosThemeData * Revert main.dart thememode * Bump version and CHANGELOG.md * minor tweak * const constructor * add DefaultWidgetsLocalizations.delegate * macro docs * export util in library rather than macos_ui * changes that were supposed to be in previous commit * Add in some required changes that got lost * Allow passing an Icon widget to IconButton This alllows developers to have better control over colors. The color property has also been renamed to backgroundColor * Update version, changelog, remove unused foregroundColor * Update version, changelog, remove unused foregroundColor * update lock file * Update docs * 0.2.2. Macos colors (#113) * Rename colors.dart * Add and export macos_colors.dart * Update version, changelog * Add documentation * Add canvasColor to MacosThemeData and apply it to Scaffold (#116) * Update github templates (#112) * Update github templates * Fixed issues * Update feature_request.md * Fix text field (#118) * Fix text field * Bump version & update changelog Co-authored-by: GroovinChip <groovinchip@gmail.com> * Add prefixes to overlapping widgets/classes (#117) * Add prefixes to overlapping widgets/classes, update version/changelog * Update widget names in readme * run dartfmt on tooltip.dart * run dartfmt on macos_theme.dart * Add missing backtick * code_metrics_reporter (#119) * Add a missing comma * Add code metrics step * Try to fix failing pub get * Break out steps a little further * Do checkout first * showcase_app (#121) * Start working on showcase * More showcase work * Wrap up refactor * Fix clicks * Fix textfield * Update text_field.dart (#122) * SidebarItem (#123) * Initial work * initial work * Focus change now works as expected, with one bug TextField focus changes remove the focus from the SidebarItem * Move to the material BottomNavigationBar paradigm for setting color * Update text color * Add docs * Bump version, update changelog * Address PR feedback * Clamp sidebar's scroll physics in demo * Add 122 to changelog * Rework sidebar items * Improved documentation * Hover color * Add visual density * Improved focusing and visual density * Implement disclosure side bar item * Add inherited properties that can be defined on the SidebarItems constructor * Addressed review Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com> Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
canvasColorproperty toMacosThemeDatacanvasColortoScaffoldScaffoldpreviously set for itsbackgroundColoris now set tocanvasColorinMacosThemeDataCloses #116
Pre-launch Checklist
dartfmton all changed filesCHANGELOG.mdwith my changesflutter pub publish --dry-runand addressed any warnings