Remove expanded path #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby is smart enough to find thin/* with autoload or require. Forcing a full path into it do not result in better performance, on the contrary, impact on performance on Windows :-( 'lib' directory is always pushed into $LOAD_PATH when running specs, but you can manually run bin/thin like this: ruby -Ilib bin/thin
|
+1 |
|
Indeed that was dumb. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thin::ROOTis defined and used to use full paths on both autoload and require.There is no proven performance improvement on the usage of forced path instead of letting Ruby figure it out.
There is also a downside on performance on Windows (which I'm investigating)
Letting Ruby resolve the path works 99% of the cases, being only when running from source the only scenario that requires special flags:
Even rspec adds
libto$LOAD_PATH.This pull request removes the usage of
Thin::ROOTin both autoload and require.Also ignores build artifacts no matter where they are placed, which seems to correct current ignore rules.
Cheers