Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some additional debugging statements to restore_ports.tcl #10

Merged
merged 4 commits into from
Sep 30, 2023

Conversation

cooljeanius
Copy link
Contributor

@cooljeanius cooljeanius commented Feb 3, 2021

I have been having some trouble using restore_ports.tcl to reinstall all my ports after migration, and so I added some additional debugging statements to the script to help me find out what has been going wrong. I'm leaving the added -d flag undocumented from the help output, as I doubt it would be useful to casual users.
(edit: note that despite the additional debugging output, it hasn't actually helped me to solve the problem I've been experiencing. I can attach the script output and my myports.txt if that would help show what's going on)

add some additional debugging statements
@cooljeanius
Copy link
Contributor Author

cc @jmroot

@cooljeanius
Copy link
Contributor Author

cooljeanius commented May 17, 2021

so, there's a conflict now after @jmroot's c69a968... how should we go about resolving it?

@cooljeanius
Copy link
Contributor Author

Can anyone else help?

@cooljeanius
Copy link
Contributor Author

so, there's a conflict now after @jmroot's c69a968... how should we go about resolving it?

oh wait I think the actual conflicting commit was a7589c1; let me try incorporating that one...

@cooljeanius
Copy link
Contributor Author

ok I think I fixed the merge conflict

@cooljeanius
Copy link
Contributor Author

ok, so since the review comments are now marked as resolved, can this be merged now?

@cooljeanius
Copy link
Contributor Author

There were some new conflicts that arose, but I fixed them

@lawyoum
Copy link

lawyoum commented May 18, 2023

👍🏻

@cooljeanius cooljeanius requested a review from raimue July 15, 2023 02:45
@cooljeanius
Copy link
Contributor Author

@raimue @mascguy @jmroot do I need to do anything else to get this merged?

@mascguy
Copy link
Member

mascguy commented Sep 19, 2023

@raimue @mascguy @jmroot do I need to do anything else to get this merged?

The option to optionally output more info is definitely a good thing, so I definitely support this. (With the caveat that I haven't tested it.)

Josh/Rainer, your folks' thoughts?

@cooljeanius
Copy link
Contributor Author

@raimue @mascguy @jmroot do I need to do anything else to get this merged?

The option to optionally output more info is definitely a good thing, so I definitely support this. (With the caveat that I haven't tested it.)

Josh/Rainer, your folks' thoughts?

Is there anyone else who could merge? @ryandesign perhaps?

@l2dy l2dy merged commit 299af8d into macports:master Sep 30, 2023
@l2dy
Copy link
Member

l2dy commented Sep 30, 2023

Merged. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants