unison: update to 2.51.4

[someuser12]

unison 2.51.4 builds with the current ocaml version (4.12) provided lablgtk2 is also updated (#12436).

See: https://trac.macports.org/ticket/62572

Description

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.15.7 19H1419 x86_64
Xcode 12.4 12D4e

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[pmetzger]

I merged the lablgtk2 fix.

[someuser12]

Thanks a lot. Do you know how to trigger a new CI build, now that lablgtk2 was updated, without changing the commit?

[pmetzger]

I've triggered a re-run.

[someuser12]

@pmetzger I see you've updated the ocaml port to release 4.12.1 after lablgtk2 was updated to 2.8.11. I think lablgtk2 now needs to be rev-bumped to be rebuilt with the latest ocaml (see #12472). Otherwise, building ports which depend on lablgtk2 fails with Error: Files /opt/local/lib/ocaml/site-lib/lablgtk2/lablgtk.cmxa and /opt/local/lib/ocaml/stdlib.cmxa make inconsistent assumptions over implementation Stdlib__nativeint.

[pmetzger]

Yah, that's true, and the various OCaml ports sadly require manual bumps after updates. Anyway, I bumped that and I'm re-starting again.

[someuser12]

Run failed while fetching sound-theme-freedesktop (which didn't change recently). Possibly a network failure? Related to the present DNS failure of facebook.com and co?

[someuser12]

I don't know if this is the best way to do it, but I added an explicit dependency to gtk2 to the unison port since my unison was broken after a recent upgrade of gtk2 from 2.24.32_0 to 2.24.33_0 which didn't trigger a rebuild of unison (nor of lablgtk2). The message was dyld: Symbol not found: _g_cclosure_marshal_VOID__POINTER Referenced from: /opt/local/bin/unison Expected in: /opt/local/lib/libgtk-x11-2.0.0.dylib in /opt/local/bin/unison

[pmetzger]

An upgrade of an upstream shared library would not necessarily trigger a rebuild of a downstream dependency. One probably has to bump the revision number to do that. Adding the gtk dependency will not fix the problem I suspect.

[someuser12]

Therefore, do you suggest that I revert adding gtk2 as a dependency? And possibly add a note to the gtk2 port that unison should be rev-bumped when gtk2 is updated?

[pmetzger]

Yes, you should not depend on it as it isn't a direct dependency.

Generally, the ocaml ports need to be rev bumped when libraries they use are altered.

[someuser12]

Thanks, done.

[pmetzger]

My suggestion is that we update OCaml to 4.13.1 and rev bump all OCaml using ports at the same time.