Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kerberos5: Update Portfile to better handle Python version #19728

Closed
wants to merge 1 commit into from

Conversation

Zweihorn
Copy link
Contributor

@Zweihorn Zweihorn commented Aug 2, 2023

ref https://trac.macports.org/ticket/67889#comment:2

Description

Avoid python branch deviates from version in Portfile.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.7.9 20G1426 x86_64
Xcode 13.0 13A233

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port kerberos5.

@Zweihorn Zweihorn changed the title Update Portfile to better handle Python version kerderos5: Update Portfile to better handle Python version Aug 2, 2023
@ryandesign
Copy link
Contributor

You haven't followed the commit message guidelines, but as I mentioned in the ticket, I want to see if we can remove the python dependency entirely since it doesn't seem to make a difference.

@ryandesign ryandesign changed the title kerderos5: Update Portfile to better handle Python version kerberos5: Update Portfile to better handle Python version Aug 3, 2023
@Zweihorn
Copy link
Contributor Author

Zweihorn commented Aug 3, 2023

You haven't followed the commit message guidelines, but as I mentioned in the ticket, I want to see if we can remove the python dependency entirely since it doesn't seem to make a difference.

THX and I will seek to improve next time.
At your deliberation as maintainer. I stay interested to see the outcome and as I said "just an idea". Feel free.

🌻

@reneeotten
Copy link
Contributor

@ryandesign - you want to close this PR and try to remove the Python dependency?

@Zweihorn Zweihorn deleted the patch-1 branch August 22, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants