Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddy: checksum mismatch in go dep #22264

Closed
wants to merge 1 commit into from
Closed

caddy: checksum mismatch in go dep #22264

wants to merge 1 commit into from

Conversation

mrdomino
Copy link
Contributor

Description

Caddy fails to build with a checksum error. Apparently the checksum, but not file size, of the tar file for imdario-mergo-v0.3.12.tar.gz has changed.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mohd-akram for port caddy.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Jan 19, 2024
@mrdomino
Copy link
Contributor Author

https://trac.macports.org/ticket/69132 tracks.

@mrdomino
Copy link
Contributor Author

Figured out what's going on: https://trac.macports.org/ticket/69132#comment:1

@mohd-akram do you happen to have any idea how to sync the distfiles between macports and github?

@mrdomino mrdomino closed this Jan 19, 2024
@pmetzger
Copy link
Member

If the issue is a stealth update, see the section of the macports guide for dealing with stealth updates.

@mrdomino
Copy link
Contributor Author

Sounds like we should change the dist_subdir for that dependency but not bump the revision, since there is no meaningful change (it's a case of "the base directory got renamed.")

Dunno how to change dist_subdir for a go dep.

@mrdomino
Copy link
Contributor Author

Oh fun, something is expecting to extract imdario-mergo-* instead of darccio-mergo-* and the build is now broken on that too.

@mrdomino mrdomino reopened this Jan 19, 2024
@mrdomino mrdomino changed the title [DO NOT MERGE] caddy: checksum mismatch in go dep caddy: checksum mismatch in go dep Jan 19, 2024
@mrdomino
Copy link
Contributor Author

Ok, so I had gotten the diff backwards — the current base directory of imdario-mergo-v0.3.12.tar.gz on github starts with darccio-mergo. What's happening is that the base directory has gotten out of step with the archive (and repo) name somehow.

@mrdomino
caddy: github username change on mergo
d0a25e5 
codeload.github.com/imdario/mergo now winds up downloading from @darccio
instead of @imdario. The changed username changed the base directory in
the tar file, changing the checksum and breaking the build.

Confirmed manually that there are no file diffs between the old and new
archives, just the base name diff.
@mrdomino
Copy link
Contributor Author

Ok, I think the user just changed their name. Github is redirecting from imdario/mergo to darccio/mergo and the generated tar file is being given the new user's name, which also updates the base dir.

This is really nasty. It breaks dependencies trying to import github.com/imdario/mergo.

@mrdomino
Copy link
Contributor Author

This is now officially above my paygrade; I'm going to close this and let further work happen on Trac.

@mrdomino mrdomino closed this Jan 19, 2024
@mrdomino mrdomino deleted the imdario-cksum branch January 19, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port
Milestone
No milestone
3 participants
@mrdomino @macportsbot @pmetzger