Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryfs: update to 0.11.4 #22436

Merged
merged 1 commit into from
Jan 30, 2024
Merged

cryfs: update to 0.11.4 #22436

merged 1 commit into from
Jan 30, 2024

Conversation

jolan78
Copy link
Contributor

@jolan78 jolan78 commented Jan 28, 2024

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7 21G816 arm64
Xcode 13.3 13E113

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to use Python 3.12 as that is now MacPorts' default Python version.

@ryandesign
Copy link
Contributor

  • referenced existing tickets on Trac with full URL?

Please reference the ticket URL in the commit message in the standard way.

@@ -43,6 +43,8 @@ depends_build-append path:lib/libssl.dylib:openssl \
depends_lib-append port:curl \
port:libomp

cmake.module_path-append ${prefix}/lib/libfmt10/cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmake.module_path-append ${prefix}/lib/libfmt10/cmake
# This has to match the version of libfmt used by spdlog.
# See https://trac.macports.org/ticket/68248
cmake.module_path-append ${prefix}/lib/libfmt10/cmake

* update to version 0.11.4
* specify libfmt port to be used according to spdlog

Closes: https://trac.macports.org/ticket/69167
@pmetzger
Copy link
Member

Looks like the requested changes were made, so I'm going to commit. Thanks, @jolan78 and thanks to everyone who reviewed.

@pmetzger pmetzger merged commit 4c823d4 into macports:master Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants