Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

girara: Update to 0.4.2 #22556

Merged
merged 1 commit into from
Feb 8, 2024
Merged

girara: Update to 0.4.2 #22556

merged 1 commit into from
Feb 8, 2024

Conversation

ryandesign
Copy link
Contributor

Description

  • Update to 0.4.2
  • Use gitlab portgroup instead of specifying homepage, master_sites, livecheck manually
  • Use compiler.c_standard instead of blacklisting compilers manually; project now uses C17 not C11
  • Remove platforms darwin; that's the default now
  • Change pkgconfig build dependency to path syntax so that pkgconf could satisfy it
  • Remove intltool build dependency because this project doesn't use it, at least not anymore
  • Add gettext build dependency because it uses msgfmt
  • Add gettext-runtime library dependency because it links with libintl.dylib
  • Remove libnotify library dependency because libnotify support is now off by default and has been removed from subsequent upstream code already
  • JSON support is now provided by json-glib not json-c
  • Add -Ddocs=disabled to configure.args on all systems not just on pre-Lion, otherwise it looks for doxygen, but even if it finds doxygen, what it builds with it doesn't seem to get installed

I have not tested the pre-existing patch for pre-Lion systems that adds implementations of getline and getdelim and do not understand how they could ever have worked since the patch only adds new source code files; it never references them from anywhere.

Closes: https://trac.macports.org/ticket/69271

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.2 21G1974 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Also:

* Use gitlab portgroup instead of specifying homepage, master_sites, and
  livecheck manually
* Use compiler.c_standard instead of blacklisting compilers manually;
  project now uses C17 not C11
* Remove platforms darwin; that's the default now
* Change pkgconfig build dependency to path syntax so that pkgconf could
  satisfy it
* Remove intltool build dependency because this project doesn't use it,
  at least not anymore
* Add gettext build dependency because it uses msgfmt
* Add gettext-runtime library dependency because it links with
  libintl.dylib
* Remove libnotify library dependency because libnotify support is now
  off by default and has been removed from subsequent upstream code
  already
* JSON support is now provided by json-glib not json-c
* Add -Ddocs=disabled to configure.args on all systems not just on
  pre-Lion, otherwise it looks for doxygen, but even if it finds doxygen,
  what it builds with it doesn't seem to get installed

Closes: https://trac.macports.org/ticket/69271
@macportsbot
Copy link

Notifying maintainers:
@harciga for port girara.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Feb 5, 2024
@pmetzger pmetzger merged commit 36eb9be into macports:master Feb 8, 2024
6 checks passed
@ryandesign ryandesign deleted the girara branch February 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update
3 participants