-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py-htseq: update to 0.10.0; add Python 3.6 #2340
Conversation
Travis Build #3181 Passed. Lint results
Port py-htseq success on xcode9.4. Log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy! Thanks so much for the update! Small comments below. I note that the portfile looks a bit unusual, so I'm going to ask some folks who understand Python portfiles better than me to also have a look.
python/py-htseq/Portfile
Outdated
|
||
python.versions 27 | ||
python.versions 27 36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't 3.7 also be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency pysam is not yet 3.7-compatible in the latest release - pysam-developers/pysam#697
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The real reason was that I forgot to add 37 and test with it, but @yan12125's justification is surely better... 😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I think a comment should be added saying that when pysam is available 3.7 should be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll do it later.
@reneeotten Could you have a look at the whole Portfile? |
I updated the pull request, adding a comment on py-pysam and Python 3.7, as requested. |
Merged. Thank you, @dliessi! |
Travis Build #3188 Passed. Lint results
Port py-htseq success on xcode9.4. Log |
Description
Type(s)
Tested on
macOS 10.11.6 15G22010
Xcode 8.2.1 8C1002
Verification
Have you
port lint
?sudo port -vst install
?