Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-htseq: update to 0.10.0; add Python 3.6 #2340

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

dliessi
Copy link
Contributor

@dliessi dliessi commented Aug 6, 2018

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.11.6 15G22010
Xcode 8.2.1 8C1002

Verification

Have you

@macportsbot macportsbot added maintainer maintainer: open Affects an openmaintainer port type: update labels Aug 6, 2018
@macportsbot
Copy link

Travis Build #3181 Passed.

Lint results
--->  Verifying Portfile for py-htseq
--->  0 errors and 0 warnings found.

Port py-htseq success on xcode9.4. Log
Port py27-htseq success on xcode9.4. Log
Port py36-htseq success on xcode9.4. Log
Port py-htseq success on xcode8.3. Log
Port py27-htseq success on xcode8.3. Log
Port py-htseq success on xcode7.3. Log
Port py27-htseq success on xcode7.3. Log
Port py36-htseq success on xcode7.3. Log

Copy link
Member

@pmetzger pmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy! Thanks so much for the update! Small comments below. I note that the portfile looks a bit unusual, so I'm going to ask some folks who understand Python portfiles better than me to also have a look.


python.versions 27
python.versions 27 36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't 3.7 also be added?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency pysam is not yet 3.7-compatible in the latest release - pysam-developers/pysam#697

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The real reason was that I forgot to add 37 and test with it, but @yan12125's justification is surely better... 😅)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think a comment should be added saying that when pysam is available 3.7 should be added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll do it later.

@pmetzger pmetzger requested a review from yan12125 August 6, 2018 12:40
@pmetzger
Copy link
Member

pmetzger commented Aug 6, 2018

@reneeotten Could you have a look at the whole Portfile?

@dliessi
Copy link
Contributor Author

dliessi commented Aug 6, 2018

I updated the pull request, adding a comment on py-pysam and Python 3.7, as requested.

@pmetzger pmetzger merged commit 58f904b into macports:master Aug 6, 2018
@pmetzger
Copy link
Member

pmetzger commented Aug 6, 2018

Merged. Thank you, @dliessi!

@macportsbot
Copy link

Travis Build #3188 Passed.

Lint results
--->  Verifying Portfile for py-htseq
--->  0 errors and 0 warnings found.

Port py-htseq success on xcode9.4. Log
Port py27-htseq success on xcode9.4. Log
Port py36-htseq success on xcode9.4. Log
Port py-htseq success on xcode8.3. Log
Port py27-htseq success on xcode8.3. Log
Port py-htseq success on xcode7.3. Log
Port py27-htseq success on xcode7.3. Log
Port py36-htseq success on xcode7.3. Log

@dliessi dliessi deleted the py-htseq branch December 22, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants