Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evolution-data-server: update to 3.52.1, allow builds without webkit2 #23657

Closed

Conversation

barracuda156
Copy link
Contributor

@mascguy I am making this a draft, please review :)
It builds fine with no hacks like this, but I am not sure about some conditionals. (Probably we rather use OS version, not C++ runtime, since it is rather likely that everything can be built against libstdc++, just not on 10.5 or at least not yet.)

Closes: https://trac.macports.org/ticket/69798

Description

Update, allow building on systems where webkit2 is broken.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mascguy for port evolution-data-server.

@barracuda156
Copy link
Contributor Author

Ah, well, it wants a much newer webkit2 than Macports has:

  -- Checking for module 'webkit2gtk-4.1>=2.34.0'
  --   No package 'webkit2gtk-4.1' found
  CMake Error at cmake/modules/PkgConfigEx.cmake:32 (message):
    Necessary libraries not found or not enough version.  If you want to
    disable WebKitGTK gtk3 for built-in OAuth2 authentications, please use
    -DENABLE_OAUTH2_WEBKITGTK=OFF argument to cmake command.
  Call Stack (most recent call first):
    CMakeLists.txt:427 (pkg_check_modules_for_option)
  
  
  -- Configuring incomplete, errors occurred!

@mascguy Should we fall back to the last version which work with an old WebKit2 or rather disable OAuth2 for the time-being, and have this version building?

@mascguy
Copy link
Member

mascguy commented Apr 22, 2024

Ah, well, it wants a much newer webkit2 than Macports has:

  -- Checking for module 'webkit2gtk-4.1>=2.34.0'
  --   No package 'webkit2gtk-4.1' found
  CMake Error at cmake/modules/PkgConfigEx.cmake:32 (message):
    Necessary libraries not found or not enough version.  If you want to
    disable WebKitGTK gtk3 for built-in OAuth2 authentications, please use
    -DENABLE_OAUTH2_WEBKITGTK=OFF argument to cmake command.
  Call Stack (most recent call first):
    CMakeLists.txt:427 (pkg_check_modules_for_option)
  
  
  -- Configuring incomplete, errors occurred!

@mascguy Should we fall back to the last version which work with an old WebKit2 or rather disable OAuth2 for the time-being, and have this version building?

Are you sure the various other dependencies are sufficient? Given how much newer this version is, you're likely to be blocked by other dependencies.

I'd like to suggest we avoid updating this port, if at all possible. Which port(s) depend on this for your system?

@mascguy
Copy link
Member

mascguy commented Apr 22, 2024

Fixed via master, so this is no longer needed

@mascguy mascguy closed this Apr 22, 2024
@barracuda156 barracuda156 deleted the evolution-data-server branch April 23, 2024 04:05
@barracuda156
Copy link
Contributor Author

@mascguy Thank you, that fixed the problem with it. (I leave updating matter to you.)

@barracuda156
Copy link
Contributor Author

@mascguy Ah, wait, it is not resolved yet, google-online-accounts still requires WebKit2, and it is an optional dependency, but the port makes it required even without a variant.

mascguy added a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants