Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfilezilla: new port, version 0.10.1 #756

Merged
merged 1 commit into from
Sep 10, 2017
Merged

libfilezilla: new port, version 0.10.1 #756

merged 1 commit into from
Sep 10, 2017

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Sep 8, 2017

Description

Required by newer FileZilla.

Closes: https://trac.macports.org/ticket/50514

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.12.6 16G29
Xcode 8.3.3 8E3004b

Verification

Have you

  • followed our Commit Message Guidelines?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@yan12125
Copy link
Contributor Author

Hmmm it's strange that builds on Travis CI timed out after 50 minutes. It takes less than 3 minutes to build on my Macbook Air.

sudo port -vt build libfilezilla  195.51s user 53.16s system 145% cpu 2:51.07 total

@raimue
Copy link
Member

raimue commented Sep 10, 2017

Travis also has to build all the dependencies that are not binary distributable, which includes doxygen, ghostscript, poppler, ...

However, builds for me locally. Thank you for your contribution.

@raimue raimue merged commit d54a131 into macports:master Sep 10, 2017
@yan12125
Copy link
Contributor Author

Thanks for the explanation! I think it's possible to make Travis CI builds faster and proposed my idea at https://trac.macports.org/ticket/54800

@yan12125 yan12125 deleted the add-libfilezilla branch September 10, 2017 15:59
chenguokai pushed a commit to chenguokai/macports-ports that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants