Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-cipheycore: Fix python3 configuration #9964

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

harens
Copy link
Member

@harens harens commented Feb 8, 2021

Description

Apologies for all these bug fixes for cipheycore. Loads of Ciphey users who use macOS have issues with cipheycore (e.g. Ciphey/Ciphey#256 Ciphey/Ciphey#362), which is why I think it's so important to have a working MacPorts portfile. Hopefully, this should be the last bug fix before adding ciphey.

cipheycore builds fine if only it's equivalent python version is active (i.e. py38-cipheycore builds fine if only python38 is active). This is fine for the buildbots, but not if the user has to build from source and has different python versions active. If the wrong python version is found, a segmentation fault occurs at runtime. This sort of issue is very similar to https://trac.macports.org/ticket/59946, and a temporary fix before this PR is merged would be to use trace mode.

The reason why this happens is explained here Ciphey/Ciphey#238 (comment).

This bug fix manually sets the build dependency python to be used during the configure stage. It sets -DCIPHEY_CORE_PYTHON to the folder containing the python headers (see https://github.com/Ciphey/CipheyCore#linuxosxother-unices).

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.1 20C69
xcode-select version 2384.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot macportsbot added maintainer maintainer: open Affects an openmaintainer port type: bugfix labels Feb 8, 2021
@cjones051073 cjones051073 merged commit 8633670 into macports:master Feb 8, 2021
@harens
Copy link
Member Author

harens commented Feb 8, 2021

Thank you very much @cjones051073.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants