pr: Do not exceed GitHub comment mention limit #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2dy
requested changes
Nov 11, 2021
pr/webhook/pull_request.go
Outdated
| err = receiver.githubClient.CreateComment(owner, repo, number, &body) | ||
| if err != nil { | ||
| log.Println(err) | ||
| i++ |
There was a problem hiding this comment.
Please add more spacing around this (add an empty line both above and below it) and maybe add comments about how i works.
There was a problem hiding this comment.
I have added comments to try explaining how the counter i is used to split handles into batches of ≤50. But maybe what I am after is a more idiomatic way of splitting handles into batches of 50, and then using a nested loop over each handle in each batch, obviating the need for a counter.
chrstphrchvz
force-pushed
the
notify-split
branch
from
c915380
to
77277ee
Compare
chrstphrchvz
force-pushed
the
notify-split
branch
from
77277ee
to
431e48a
Compare
|
The created GitHub comments should now also indicate which batch they are for, e.g.:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://trac.macports.org/ticket/63821
I’ve not used Go before. Untested; I’m not sure I could test this any sooner than someone more familiar with the PR bot.