Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed xpath for series, and tried to add to collection #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pofo14
Copy link

@pofo14 pofo14 commented May 13, 2020

Series was not getting parsed at all. Fixes issue with the xpath, most likely due to html change.

Tried to add functionality to save series to the Collection Tag - code has no errors - but the tags do not save.

@macr0dev
Copy link
Owner

Audible likes to make little tweaks and break things for me. :)

Collections have never really worked right on music, that's why it ended up in the genre tag. It was the only real place I could stick it to be useful for filtering. Once upon a time, you could even click the genre in the web client and it would load the ones matching, which is why the series was first on that list - but that's not working anymore either.

With the introduction of the new android client, Chronicle Audiobook Player - I'm taking a look at a few more things. I'll see if I can figure out the collections issue.

Question for you - have you ever seen Audible tag a book with more than one series? I noticed you appeared to be trying to account for that.

@pofo14
Copy link
Author

pofo14 commented May 22, 2020 via email

@macr0dev
Copy link
Owner

I'll go looking around at the harry potter series. Always need a good use case for testing stuff like that.

Running it through Plex is the only way to test it I know of. I've discovered another coder on the plex forums who was attempting do collections in music libraries a year or two ago, so I've reached out to him to see if he had any success. Fingers crossed. Thanks for contributing!

If you're an android guy, go check out the Chronicle Audiobook Player. It works with plex. It's not my app, but I'm testing it out. Just trying to help share the love.

@jmeosbn
Copy link

jmeosbn commented May 23, 2020 via email

@pofo14
Copy link
Author

pofo14 commented May 23, 2020 via email

@jmeosbn
Copy link

jmeosbn commented May 23, 2020 via email

@jmeosbn
Copy link

jmeosbn commented May 25, 2020

Here's the image I had attached in email reply.

90D5807A-5144-40B8-9F82-FF1F6258BF4D

@macr0dev
Copy link
Owner

I've done a little digging around in the metadata xml files and it's kind of interesting the way it both stores and ignore collection data.

Even for movies the collection names stored in the Info.xml (be it in the agent dir or _combined dir) aren't necessarily the ones displayed or used in the UI. I have movies that have collections pulled from agents that are stored in both Info.xml files but have been overwritten in the UI or deleted entirely. But they're still there. Conversely, if I assign an object to a collection it doesn't write that name to either of these files.

So from all of this we know several things:

  1. The agent IS properly handing off the collection data to Plex.
  2. There is a second location where collection data (and possibly other data) is stored.

Unrelated PS - Children of Titan is an awesome series. I'm listening to the last book now, and prominently display my signed copy of Titanborn that Rhett sent me on my bookshelf.

@jmeosbn
Copy link

jmeosbn commented May 27, 2020

Ha, yes it is a good series. There's a whole thing with agents "contributing to" and then the order you may prioritise in the UI.

On top of that is your own manually set data - which appears to go into the sql db.

Then Plex itself decides to not show some of it!

There are also tags that you can set set as "tags" (but only with a plex pass), labels and source (where??) -- all would be useful and are listed as (empty) filters.

I'm setting narrators in to "moods" and used to use "styles" for series, but now I mix them with genres (it makes sense to me).

I added PRs previously (I think for some of the above) but eventually it got too hard to keep my fork in sync when the PRs weren't merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants