Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalman Filter update #13

Merged
merged 10 commits into from
Jan 27, 2023
Merged

Kalman Filter update #13

merged 10 commits into from
Jan 27, 2023

Conversation

Allen-ENGI
Copy link
Contributor

Hello, I put all the necessary codes and the testing video in the file. There is also a description.md for the explanation.

@Bill-Haoyu-Lin
Copy link
Member

Bill-Haoyu-Lin commented Jan 10, 2023

Can you provide some supporting testing information thanks! (for example video of result) Great work!
Also can you use armor plate instead of orange?

Copy link
Member

@Bill-Haoyu-Lin Bill-Haoyu-Lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code need to be changed to fit RM armor plate detection, instead of detecting an orange

@Allen-ENGI
Copy link
Contributor Author

I have deleted the useless functions and changed the description.txt.

@Bill-Haoyu-Lin
Copy link
Member

Great work! Can we have some testing record/data? (please include the code on demo in comment session) Thanks

@Allen-ENGI
Copy link
Contributor Author

Ok, I will update the file

@Bill-Haoyu-Lin
Copy link
Member

Ok, I will update the file

Have something like "how to use it in our code" will be really helpful. I have no idea how to use it now

@Allen-ENGI
Copy link
Contributor Author

Ok, I will update the file

Have something like "how to use it in our code" will be really helpful. I have no idea how to use it now

Will add that part to description.md, thanks for bringing it up.

@Bill-Haoyu-Lin
Copy link
Member

Ok, I will update the file

Have something like "how to use it in our code" will be really helpful. I have no idea how to use it now

Will add that part to description.md, thanks for bringing it up.

Or you can just put it on top of your code
image

And remove the description.md put all information under this pull request comment or move it to code comment part
you can use this template

################################################
#function name:
#function description:
#function call demo code: 
################################################

@Allen-ENGI
Copy link
Contributor Author

Removed the Folder and add commented to the kalmanfilter.py file

@Bill-Haoyu-Lin Bill-Haoyu-Lin merged commit b876dc3 into macrobomaster:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants