Migrate MACS2 to Python3 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 3str and edit pyx codes accordingly.
… filterdup. Remove -g flag during compilation.
…correctly write trackline in bed output.
…specify 'bytes' type
…show weird large values. fix cmbreps and BedGraph for py3
…for test.sh to compare.
… np.mat with np.array.
Closed
jessie-wangjie
approved these changes
Oct 2, 2019
taoliu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first release under Python3 (#242). Changes are:
Features added
First Python3 version MACS2 released.
Version number 2.2.X will be used for MACS2 in Python3, in
parallel to 2.1.X.
More comprehensive test.sh script to check the consistency of
results from Python2 version and Python3 version.
Simplify setup.py script since the newest version transparently
supports cython. And when cython is not installed by the user,
setup.py can still compile using only C codes.
Fix Signal.pyx to use np.array instead of np.mat.